Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Port sunshine config from bazzite #29

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

linkion
Copy link

@linkion linkion commented Dec 11, 2024

Here is a pull request for porting over sunshine to be used within Aurora.

I don't know how bazzite was able to install sunshine with

rpm-ostree install --apply-live -y sunshine

I did instead replace it with the copr provided by lizardbyte. However, because the stable copr repo doesn't have a stable build of Sunshine, I'm using the beta repo, which does have a recent build.

dnf5 copr enable -y lizardbyte/beta
rpm-ostree install --apply-live -y Sunshine

I don't necessarily know how to test this though, I have tried to run with just run aurora stable nvidia, but it seems that systemd isn't used so I can't test if the service runs properly, and building and running an iso with just run-iso aurora stable fails on installation of the OS in the vm.

The issue linked with this pull request: #28

@linkion linkion requested a review from castrojo as a code owner December 11, 2024 08:16
@linkion linkion changed the title Port sunshine config from bazzite feat: Port sunshine config from bazzite Dec 11, 2024
@linkion
Copy link
Author

linkion commented Dec 14, 2024

Sunshine is currently being pulled from Lizardbyte/beta, but we probably don't want beta software on stable.

I raised an issue about it with them, and they said that the copr was made recently, so it should be built into the next stable release.

Seeing that their last stable release [v0.23.1] was last released on April 20, it might take a while for their next release.

I'll try to pull from their latest release and install the .rpm file instead.

@linkion
Copy link
Author

linkion commented Dec 14, 2024

Lol, nvm, they only have up to Fedora 39 on their latest release, with even their pre-releases forgoing the Fedora package. Probably because they now have the copr setup, so they removed the RPM from GitHub releases

@RealVishy
Copy link
Contributor

RealVishy commented Dec 14, 2024

Lol, nvm, they only have up to Fedora 39 on their latest release, with even their pre-releases forgoing the Fedora package. Probably because they now have the copr setup, so they removed the RPM from GitHub releases

Rip, should we wait for a stable release on the COPR? Honestly I'm fine with shipping the beta COPR as long as it isn't too buggy/unstable. Should be fine as long as we mention it ujust setup-sunshine-beta.

@ReenigneArcher
Copy link

At this point our beta is probably less buggy than v0.23.1, and we are trying to get a new release published soon, but I can't give an accurate ETA on that.

@RealVishy
Copy link
Contributor

RealVishy commented Dec 15, 2024

yeah i can't get the iso to build either, i think we might still have to do some cleanup for bluefin stuff. I'll try to get that done in a pr quickly.

sent 48,537,467 bytes  received 3,891 bytes  97,082,716.00 bytes/sec
total size is 48,515,593  speedup is 1.00
+ rsync -rvK /ctx/system_files/silverblue/ /
sending incremental file list
rsync: [sender] change_dir "/ctx/system_files/silverblue" failed: No such file or directory (2)

sent 19 bytes  received 12 bytes  62.00 bytes/sec
total size is 0  speedup is 0.00
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1338) [sender=3.3.0]
Error: building at STEP "RUN --mount=type=cache,dst=/var/cache/rpm-ostree --mount=type=bind,from=ctx,source=/,target=/ctx /ctx/build_files/shared/build-base.sh": while running runtime: exit status 23
error: Recipe `build` failed with exit code 23
error: Recipe `build-iso` failed with exit code 23```

@linkion
Copy link
Author

linkion commented Dec 16, 2024

yeah i can't get the iso to build either, i think we might still have to do some cleanup for bluefin stuff. I'll try to get that done in a pr quickly.

sent 48,537,467 bytes  received 3,891 bytes  97,082,716.00 bytes/sec
total size is 48,515,593  speedup is 1.00
+ rsync -rvK /ctx/system_files/silverblue/ /
sending incremental file list
rsync: [sender] change_dir "/ctx/system_files/silverblue" failed: No such file or directory (2)

sent 19 bytes  received 12 bytes  62.00 bytes/sec
total size is 0  speedup is 0.00
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1338) [sender=3.3.0]
Error: building at STEP "RUN --mount=type=cache,dst=/var/cache/rpm-ostree --mount=type=bind,from=ctx,source=/,target=/ctx /ctx/build_files/shared/build-base.sh": while running runtime: exit status 23
error: Recipe `build` failed with exit code 23
error: Recipe `build-iso` failed with exit code 23```

Huh, I was able to build with just build-iso aurora stable I think successfully, since I got an iso, though I do see some kind of error at the end

implantisomd5 /github/workspace/aurora_build/aurora-stable.iso
Inserting md5sum into iso image...
md5 = f7bae8f631ab4483df33cb349035fd63
Inserting fragment md5sums into iso image...
fragmd5 = ec77212b6776625a2e3dfccfd2d333d2793993cdb652abc37e6ef41163c5
frags = 20
Setting supported flag to 0
chmod ugo=r /github/workspace/aurora_build/aurora-stable.iso
cd /github/workspace/aurora_build/ && sha256sum aurora-stable.iso > aurora-stable.iso-CHECKSUM
+ [[ 1001 -gt 0 ]]
+ just sudoif chown 1001:1001 -R /var/home/patrickorave/Documents/Code/aurora
ksshaskpass: Unable to parse phrase "[sudo] password for patrickorave: "

But when I run just run-iso aurora stable and begin the installation, I get this error message on installing fedora
Screenshot_20241215_181003

@RealVishy
Copy link
Contributor

iso build is broken for me rn, this pr should address it.
#36

@inffy
Copy link

inffy commented Dec 16, 2024

iso build is broken for me rn, this pr should address it. #36

Iso seems to build now, but if I try to run the built iso, the installer throws an error when the installation starts.

not sure if I do something wrong but same thing happens even with a clean local bluefin repo clone :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants